Skip to content

Conversation

@marcom
Copy link
Contributor

@marcom marcom commented Sep 21, 2025

This patch implements Willmott's index of agreement.

I am not familiar with this code base, so I tried to follow the implementation of the Rsquared implementation.

Some information on the measure: https://permetrics.readthedocs.io/en/latest/pages/regression/WI.html

cc: @veddox @gabo-di

Copy link
Member

@ablaom ablaom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @marcom for this valuable contribution!

Just a few minor editorial suggestions and this ready to go.

marcom and others added 2 commits September 22, 2025 16:44
Co-authored-by: Anthony Blaom, PhD <[email protected]>
Co-authored-by: Anthony Blaom, PhD <[email protected]>
@codecov
Copy link

codecov bot commented Sep 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.22%. Comparing base (2fa9c55) to head (d50f3c6).
⚠️ Report is 15 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #53      +/-   ##
==========================================
+ Coverage   91.87%   92.22%   +0.34%     
==========================================
  Files          14       14              
  Lines         714      720       +6     
==========================================
+ Hits          656      664       +8     
+ Misses         58       56       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ablaom ablaom merged commit b66adcf into JuliaAI:dev Sep 22, 2025
5 checks passed
This was referenced Sep 22, 2025
@ablaom
Copy link
Member

ablaom commented Sep 22, 2025

@marcom FYI: JuliaRegistries/General#138964

@marcom
Copy link
Contributor Author

marcom commented Sep 23, 2025

@ablaom Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants