-
Notifications
You must be signed in to change notification settings - Fork 6
Add Willmott index of agreement #53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ablaom
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @marcom for this valuable contribution!
Just a few minor editorial suggestions and this ready to go.
Co-authored-by: Anthony Blaom, PhD <[email protected]>
Co-authored-by: Anthony Blaom, PhD <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #53 +/- ##
==========================================
+ Coverage 91.87% 92.22% +0.34%
==========================================
Files 14 14
Lines 714 720 +6
==========================================
+ Hits 656 664 +8
+ Misses 58 56 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@ablaom Thank you very much! |
This patch implements Willmott's index of agreement.
I am not familiar with this code base, so I tried to follow the implementation of the
Rsquaredimplementation.Some information on the measure: https://permetrics.readthedocs.io/en/latest/pages/regression/WI.html
cc: @veddox @gabo-di